Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stability status of region #180

Merged
merged 1 commit into from Aug 3, 2023

Conversation

sun-yuliang
Copy link
Collaborator

What type of PR is this?

Enhancements

What this PR does / why we need it:

add stability status of region

Which issue(s) this PR fixes:

Special notes for your reviewer:

@sun-yuliang sun-yuliang added the workflow/draft draft: no need to review label Aug 2, 2023
@sun-yuliang sun-yuliang self-assigned this Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 83.51% and project coverage change: +0.20% 🎉

Comparison is base (472c39e) 51.32% compared to head (dae78bc) 51.53%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   51.32%   51.53%   +0.20%     
==========================================
  Files         421      422       +1     
  Lines       40672    40741      +69     
==========================================
+ Hits        20876    20994     +118     
+ Misses      17515    17454      -61     
- Partials     2281     2293      +12     
Flag Coverage Δ
unittest 51.53% <83.51%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...urce/cpu/assembler/provisionassembler/assembler.go 100.00% <ø> (ø)
...esource/cpu/assembler/provisionassembler/helper.go 94.73% <50.00%> (-5.27%) ⬇️
...u/assembler/provisionassembler/assembler_common.go 96.66% <75.00%> (ø)
...sor/plugin/qosaware/resource/cpu/advisor_helper.go 77.83% <80.00%> (+0.30%) ⬆️
...sysadvisor/plugin/qosaware/resource/cpu/advisor.go 71.31% <85.71%> (+0.34%) ⬆️
...urce/cpu/region/region_dedicated_numa_exclusive.go 83.95% <85.71%> (+0.40%) ⬆️
...plugin/qosaware/resource/cpu/region/region_base.go 74.55% <87.50%> (+0.99%) ⬆️
...isor/plugin/qosaware/resource/cpu/region/region.go 100.00% <100.00%> (ø)
...lugin/qosaware/resource/cpu/region/region_share.go 73.52% <100.00%> (+0.80%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

waynepeking348
waynepeking348 previously approved these changes Aug 2, 2023
@sun-yuliang sun-yuliang added workflow/need-review review: test succeeded, need to review and removed workflow/draft draft: no need to review labels Aug 3, 2023
@sun-yuliang sun-yuliang changed the title WIP: add stability status of region add stability status of region Aug 3, 2023
@sun-yuliang sun-yuliang force-pushed the syl/add-region-status branch 2 times, most recently from 7fb64b2 to ca5dbd4 Compare August 3, 2023 08:03
@waynepeking348 waynepeking348 merged commit 2993490 into kubewharf:main Aug 3, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants