Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qrm): only one periodical handler get executed #186

Merged
merged 1 commit into from Aug 4, 2023

Conversation

zzzzhhb
Copy link
Collaborator

@zzzzhhb zzzzhhb commented Aug 4, 2023

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

only one periodical handler get executed when there are multiple handlers.

Special notes for your reviewer:

@zzzzhhb zzzzhhb added bug Something isn't working workflow/need-review review: test succeeded, need to review workflow/merge-ready merge-ready: code is ready and can be merged labels Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.09% 🎉

Comparison is base (a049d1f) 51.26% compared to head (2b5f1c4) 51.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   51.26%   51.35%   +0.09%     
==========================================
  Files         422      422              
  Lines       40772    40773       +1     
==========================================
+ Hits        20900    20938      +38     
+ Misses      17585    17547      -38     
- Partials     2287     2288       +1     
Flag Coverage Δ
unittest 51.35% <66.66%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lcomponent/periodicalhandler/periodical_handler.go 48.20% <66.66%> (-4.70%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waynepeking348 waynepeking348 merged commit aab4bf9 into kubewharf:main Aug 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/merge-ready merge-ready: code is ready and can be merged workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants