Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: monitoring accuracy and latency of reported information in KCNR #237

Merged
merged 1 commit into from
Oct 9, 2023
Merged

feat: monitoring accuracy and latency of reported information in KCNR #237

merged 1 commit into from
Oct 9, 2023

Conversation

zhy76
Copy link
Contributor

@zhy76 zhy76 commented Aug 24, 2023 •
edited

What type of PR is this?

What this PR does / why we need it:

feat: monitoring accuracy and latency of reported information in KCNR

Which issue(s) this PR fixes:

Fixes: #161

Special notes for your reviewer:

@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited

Codecov Report

Attention: 142 lines in your changes are missing coverage. Please review.

Comparison is base (a3bef5b) 53.02% compared to head (3bfd794) 53.32%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   53.02%   53.32%   +0.29%     
==========================================
  Files         397      400       +3     
  Lines       43438    43803     +365     
==========================================
+ Hits        23034    23358     +324     
- Misses      17861    17877      +16     
- Partials     2543     2568      +25
Flag Coverage Δ
unittest 53.32% <60.66%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cmd/katalyst-controller/app/options/controller.go 58.62% <66.66%> (+0.92%) ⬆️
pkg/controller/lifecycle/cnr.go 59.06% <0.00%> (ø)
pkg/util/native/object.go 61.79% <50.00%> (-0.86%) ⬇️
cmd/katalyst-controller/app/options/monitor.go 38.88% <38.88%> (ø)
pkg/controller/monitor/cnr_indicator.go 78.29% <78.29%> (ø)
pkg/controller/monitor/cnr.go 51.96% <51.96%> (ø)

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhy76 zhy76 marked this pull request as draft August 24, 2023 11:26
@zhy76 zhy76 marked this pull request as draft August 24, 2023 11:26
@zhy76 zhy76 marked this pull request as draft August 24, 2023 11:26
@caohe caohe added enhancement New feature or request workflow/draft draft: no need to review labels Aug 24, 2023
@caohe caohe added this to the v0.4 milestone Aug 24, 2023
@zhy76 zhy76 force-pushed the anomaly-metric branch 3 times, most recently from 81b3658 to e6a522f Compare August 31, 2023 06:57
@zhy76 zhy76 force-pushed the anomaly-metric branch 7 times, most recently from 7a8795b to 87193a3 Compare September 13, 2023 05:40
@zhy76 zhy76 changed the title [WIP] feat: monitoring accuracy and latency of reported information in KCNR feat: monitoring accuracy and latency of reported information in KCNR Sep 15, 2023
@zhy76 zhy76 marked this pull request as ready for review September 15, 2023 04:26
@zhy76
Copy link
Contributor Author

zhy76 commented Oct 3, 2023

Grafana and Prometheus results:
image
image

@zhy76 zhy76 force-pushed the anomaly-metric branch 2 times, most recently from 2e03185 to 89950fc Compare October 7, 2023 09:27
caohe
caohe reviewed Oct 7, 2023
View reviewed changes
pkg/config/controller/cnr.go Outdated Show resolved Hide resolved
caohe
caohe reviewed Oct 7, 2023
View reviewed changes
pkg/controller/cnr/cnr.go Outdated Show resolved Hide resolved
caohe
caohe reviewed Oct 7, 2023
View reviewed changes
pkg/controller/cnr/cnr.go Outdated Show resolved Hide resolved
caohe
caohe reviewed Oct 7, 2023
View reviewed changes
pkg/controller/cnr/cnr.go Outdated Show resolved Hide resolved
@zhy76 zhy76 force-pushed the anomaly-metric branch 2 times, most recently from d2052e8 to 84aca47 Compare October 7, 2023 12:43
luomingmeng
luomingmeng reviewed Oct 7, 2023
View reviewed changes
pkg/controller/cnr/cnr_indicator.go Outdated Show resolved Hide resolved
pkg/controller/cnr/cnr.go Outdated Show resolved Hide resolved
@zhy76 zhy76 force-pushed the anomaly-metric branch 3 times, most recently from 8d2b054 to f40f34e Compare October 8, 2023 04:56
@zhy76
Copy link
Contributor Author

zhy76 commented Oct 8, 2023

PTAL and Thanks for all your suggestions 😄

@zhy76 zhy76 force-pushed the anomaly-metric branch 2 times, most recently from 7ab9b27 to d488a7c Compare October 8, 2023 06:30
luomingmeng
luomingmeng reviewed Oct 8, 2023
View reviewed changes
pkg/controller/monitor/cnr_indicator.go Outdated Show resolved Hide resolved
pkg/controller/monitor/cnr_indicator.go Outdated Show resolved Hide resolved
pkg/controller/monitor/cnr_indicator.go Outdated Show resolved Hide resolved
@waynepeking348 waynepeking348 added the workflow/merge-ready merge-ready: code is ready and can be merged label Oct 9, 2023
@waynepeking348 waynepeking348 merged commit 3a61f04 into kubewharf:main Oct 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caohe caohe caohe approved these changes

@luomingmeng luomingmeng luomingmeng approved these changes

@zzzzhhb zzzzhhb zzzzhhb approved these changes

@csfldf csfldf Awaiting requested review from csfldf csfldf is a code owner

@pendoragon pendoragon Awaiting requested review from pendoragon pendoragon is a code owner

@waynepeking348 waynepeking348 Awaiting requested review from waynepeking348

Assignees

@zhy76 zhy76

Labels
enhancement New feature or request workflow/draft draft: no need to review workflow/merge-ready merge-ready: code is ready and can be merged
Projects
Katalyst Development Dashboard
Status: 🏗 In progress
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Monitoring accuracy and latency of reported information in KCNR
5 participants
@zhy76 @caohe @luomingmeng @zzzzhhb @waynepeking348