Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(plugin): Support inter-pod affinity and anti-affinity at NUMA level #347

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yanxiaoqi932
Copy link

@yanxiaoqi932 yanxiaoqi932 commented Nov 7, 2023

What type of PR is this?

Enhancement

What this PR does / why we need it:

Support inter-pod affinity and anti-affinity at NUMA level,#220

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 311 lines in your changes are missing coverage. Please review.

Comparison is base (ec556bf) 53.79% compared to head (4b6dcdd) 54.14%.
Report is 2 commits behind head on main.

Files Patch % Lines
...g/scheduler/plugins/numainterpodaffinity/filter.go 69.57% 75 Missing and 26 partials ⚠️
pkg/scheduler/cache/cache.go 43.10% 29 Missing and 4 partials ⚠️
pkg/scheduler/cache/nodeinfo.go 66.66% 24 Missing and 9 partials ⚠️
pkg/scheduler/util/qos.go 29.54% 25 Missing and 6 partials ⚠️
pkg/util/native/pod_resource.go 24.24% 25 Missing ⚠️
pkg/util/affinity/inter_pod_affinity.go 90.68% 18 Missing and 5 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 71.83% 13 Missing and 7 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 71.83% 13 Missing and 7 partials ⚠️
pkg/scheduler/cache/resourcetopology.go 66.66% 12 Missing and 3 partials ⚠️
pkg/util/native/object.go 33.33% 4 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   53.79%   54.14%   +0.34%     
==========================================
  Files         446      452       +6     
  Lines       49420    50464    +1044     
==========================================
+ Hits        26587    27322     +735     
- Misses      19816    20078     +262     
- Partials     3017     3064      +47     
Flag Coverage Δ
unittest 54.14% <70.06%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

func (n *NodeInfo) GetAssumedPodAffinityInfo() AssumedPodAffinityInfo {
n.Mutex.RLock()
defer n.Mutex.RUnlock()
return n.AssumedPodAffinityInfo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AssumedPodAffinityInfo is not thread safe, maybe it is better to return a deepcopy ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants