feat(qrm): Support for OOM priority as a QoS enhancement #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 53.43% 53.26% -0.18%
==========================================
Files 439 444 +5
Lines 48419 48807 +388
==========================================
+ Hits 25874 25997 +123
- Misses 19608 19867 +259
- Partials 2937 2943 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
csfldf
reviewed
Nov 20, 2023
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_async_handler.go
Outdated
Show resolved
Hide resolved
pkg/agent/qrm-plugins/memory/dynamicpolicy/policy_async_handler.go
Outdated
Show resolved
Hide resolved
|
please add or refine unit-tests until passing codecov/patch check, thanks |
y-ykcir
force-pushed
the
feature/pod_webhook
branch
17 times, most recently
from
4cf9a43
to
8959b31
Compare
csfldf
previously approved these changes
Nov 27, 2023
pkg/util/qos/mem_enhancement.go
Outdated
| } | ||
|
|
||
| parsedOOMPriority, parseErr := strconv.Atoi(oomPriorityStr) | ||
|
|
There was a problem hiding this comment.
it will be better to remove those unnecessary blank lines (to keep a uniform coding styles); need to check for all those coding styles
y-ykcir
force-pushed
the
feature/pod_webhook
branch
from
8959b31
to
9407867
Compare
waynepeking348
approved these changes
Nov 28, 2023
y-ykcir
changed the title
csfldf
force-pushed
the
feature/pod_webhook
branch
from
9407867
to
d0913db
Compare
Signed-off-by: ricky <yricky509@gmail.com>
csfldf
force-pushed
the
feature/pod_webhook
branch
from
d0913db
to
fb0fdd1
Compare
csfldf
added
workflow/merge-ready
csfldf
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
#216
Special notes for your reviewer:
@csfldf