Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fitError when no available clusters #231

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

Poor12
Copy link
Collaborator

@Poor12 Poor12 commented Sep 12, 2023

When there is no available clusters, scheduler will result in a FitError, and we can get the scheduling details from events.

 Warning  ScheduleFederatedObject  17m (x4 over 17m)     scheduler                  0/3 clusters are available: 1 cluster(s) didn't match cluster selector, 2 cluster(s) were not in placement list

@gary-lgy
Copy link
Member

Looks like our webhook plugins do not return a reason when a cluster is unschedulable. Should we open an issue to track it?

@Poor12
Copy link
Collaborator Author

Poor12 commented Sep 21, 2023

Looks like our webhook plugins do not return a reason when a cluster is unschedulable. Should we open an issue to track it?

Sure, maybe we can propose one right now, such as ("cluster(s) were filtered by webhookPlugin(%s)", p.name)

@gary-lgy
Copy link
Member

Looks like our webhook plugins do not return a reason when a cluster is unschedulable. Should we open an issue to track it?

Sure, maybe we can propose one right now, such as ("cluster(s) were filtered by webhookPlugin(%s)", p.name)

I was thinking more along the lines of letting webhooks return their own reasons. This would require extending our request and response definitions. For now, I think we can adopt your suggestion.

Signed-off-by: shentiecheng <shentiecheng@bytedance.com>
auto-merge was automatically disabled September 22, 2023 06:10

Head branch was pushed to by a user without write access

@gary-lgy gary-lgy merged commit f6617c8 into kubewharf:main Sep 25, 2023
6 checks passed
miraclejzd pushed a commit to miraclejzd/kubeadmiral that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants