Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API machinery improvements #1

Closed
krisnova opened this issue Jun 30, 2017 · 1 comment · Fixed by #572
Closed

API machinery improvements #1

krisnova opened this issue Jun 30, 2017 · 1 comment · Fixed by #572

Comments

@krisnova
Copy link
Member

Right now we are vendoring in API Machinery (good) but we aren't really using it all that well (bad)

Can we tidy up our API Machinery implementation and make it awesome?

@krisnova
Copy link
Member Author

For instance we are not adding version or type to our objects

Name: knova
ServerPools:
- Cloud: azure
  Count: 1
  Name: azure-master
  Networks:
  - NetworkCidr: null
    NetworkType: public
    metadata:
      creationTimestamp: null
  PoolType: master
  Type: ""
  metadata:
    creationTimestamp: null
- Cloud: azure
  Count: 3
  Name: azure-node
  Networks:
  - NetworkCidr: null
    NetworkType: public
    metadata:
      creationTimestamp: null
  PoolType: node
  Type: ""
  metadata:
    creationTimestamp: null
metadata:
  creationTimestamp: null

@krisnova krisnova changed the title API Machinery Needs Work! API machinery improvements Jul 16, 2017
krisnova pushed a commit that referenced this issue Aug 15, 2017
krisnova pushed a commit that referenced this issue Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant