Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option FUNCHOOK_INSTALL #31

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add option FUNCHOOK_INSTALL #31

merged 1 commit into from
Oct 13, 2021

Conversation

rumblehhh
Copy link
Contributor

FUNCHOOK_INSTALL allows skipping Funchook's install step

FUNCHOOK_INSTALL allows skipping Funchook's install step
@kubo
Copy link
Owner

kubo commented Oct 13, 2021

@rumblehhh Could you post a use case of the option? What problem is avoided by it?

@rumblehhh
Copy link
Contributor Author

Sure, we're using funchook-static as a private dependency of a project and we have no need for funchook to be installed alongside our project. Users of our project don't need headers or libraries from funchook and they aren't needed after the build process (static linking).
If we were using funchook-shared or if funchook was being used a public dependency then we would have a need for the installed files.

I believe its reasonably common for libraries such as these to provide an install/skip install option.

@kubo
Copy link
Owner

kubo commented Oct 13, 2021

Thanks. I got it.

@kubo kubo merged commit da7cba4 into kubo:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants