Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain MSC defines
_WIN32
but notWIN32
and this leads to build errors like this:https://stackoverflow.com/a/74084728/9456786
https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
also CMake on recent VisualStudio is reported not to define
WIN32
as wellhttps://developercommunity.visualstudio.com/t/win32-not-defined/722576
-> Fix this by using
_WIN32
instead ofWIN32
in the sources everywhere.P.S. Thanks a lot for funchook!