Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server integration tests, support workspace directory #128

Merged
merged 9 commits into from Nov 1, 2022

Conversation

kubukoz
Copy link
Owner

@kubukoz kubukoz commented Oct 17, 2022

Adds a couple basic integration tests by running the language server in a resource directory and having it respond to a couple generic LSP requests.

Also makes the server aware of workspaceDirectories provided in the initialize request (so far using just the first one in the list).

TODO:

  • completion provider
  • diagnostic provider
  • command provider: run command
    • this and the code lens should exercise real HTTP requests to a server also managed by this. Include ember-server and make assertions on the output reported to the client.
    • happy path is enough (when it comes to validating the request), more fine-grained tests can be written as tests for the specific command provider
  • custom request (smithyql.runQuery)
  • code lens provider
  • document symbol provider
  • example involving workspace refresh (e.g. adding a new service to the scope and checking that its services can be used without errors)

@kubukoz kubukoz changed the title Server integration tests Server integration tests, support workspace directory Oct 17, 2022
@kubukoz kubukoz marked this pull request as ready for review October 31, 2022 23:53
@kubukoz kubukoz merged commit 1620250 into main Nov 1, 2022
@kubukoz kubukoz deleted the lsp-integration-test branch November 1, 2022 00:03
@kubukoz kubukoz added this to the Multi-operation files milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant