Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying service at operation name #82

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Support specifying service at operation name #82

merged 3 commits into from
Aug 18, 2022

Conversation

kubukoz
Copy link
Owner

@kubukoz kubukoz commented Aug 14, 2022 •
edited

Implements the remaining part of #12 (semantics part 1).

For example, this will support the following SmithyQL file:

playground.std#Random.NextUUID {}

without a use clause.

Extra notes:

  • if both a use clause and an explicit service reference are provided, compilation fails. It's deemed a conflict even if the same name is used in both locations.

This shows up as a diagnostic with extra information, although it seems like VS Code doesn't like that very much:

image

@kubukoz kubukoz mentioned this pull request Aug 14, 2022
Open
2 tasks
@kubukoz kubukoz marked this pull request as ready for review August 14, 2022 02:49
@kubukoz kubukoz merged commit 2fdcfef into main Aug 18, 2022
@kubukoz kubukoz deleted the operation-service-reference branch August 18, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kubukoz