Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

fix(types): type checking declarations #40

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

tozes
Copy link
Contributor

@tozes tozes commented Dec 3, 2019

In version 1.5.0, main was changed to point to lib/support instead of src which broke type checking so in order to make it work with the current package configuration, we need to explicitly indicate the main types declaration file:

before:

...
"main": "lib/support",
...

after

...
  "main": "lib/support",
  "types": "lib/index.d.ts",
...

@tozes tozes changed the title Fix types in 1.5.0 fix type checking Dec 3, 2019
@tozes tozes changed the title fix type checking fix: type checking declarations Dec 3, 2019
@kuceb
Copy link
Owner

kuceb commented Dec 3, 2019

@tozes thanks, should have had typedef tests

@kuceb kuceb changed the title fix: type checking declarations fix(types): type checking declarations Dec 3, 2019
@kuceb kuceb merged commit a26b9d0 into kuceb:master Dec 3, 2019
@kuceb
Copy link
Owner

kuceb commented Dec 20, 2019

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kuceb kuceb added the released label Dec 20, 2019
@tozes tozes deleted the fix-types-150 branch January 2, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants