Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Longer currency codes #17

Closed
danaki opened this issue Jun 9, 2018 · 3 comments
Closed

Longer currency codes #17

danaki opened this issue Jun 9, 2018 · 3 comments

Comments

@danaki
Copy link

danaki commented Jun 9, 2018

Cryptocurrencies for example MIOTA or WAVES have codes longer than 3 symbols, this number is hardcoded in money-bundle/Resources/config/doctrine/Currency.orm.xml.
@kucharovic
Copy link
Owner

Length of currency code is according to ISO 4217 standard. If you need support of longer symbols, make a pull request, please.

@danaki
Copy link
Author

danaki commented Sep 5, 2018

There's no reason to stick to this standard in underlying database layer like doctrine, since MoneyPhp supports cryptocurrencies too which do not respect any standards.

@enumag
Copy link
Contributor

enumag commented Sep 5, 2018

Agreed, send a PR.

@danaki danaki mentioned this issue Sep 5, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@enumag @danaki @kucharovic