Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codemirror to the latest version šŸš€ #135

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 20, 2018

ā˜ļø Greenkeeperā€™s updated Terms of Service will come into effect on April 6th, 2018.

Version 5.36.0 of codemirror was just published.

Dependency codemirror
Current Version 5.35.0
Type dependency

The version 5.36.0 is not covered by your current version range.

If you donā€™t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of codemirror.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you donā€™t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes 5.36.0

Version 5.36.0

Bug fixes

Make sure all document-level event handlers are registered on the document that the editor is part of.

Fix issue that prevented edits whose origin starts with + from being combined in history events for an editor-less document.

multiplex addon: Improve handling of indentation.

merge addon: Use CSS :after element to style the scroll-lock icon.

javascript-hint addon: Don't provide completions in JSON mode.

continuelist addon: Fix numbering error.

show-hint addon: Make fromList completion strategy act on the current token up to the cursor, rather than the entire token.

markdown mode: Fix a regexp with potentially exponental complexity.

New features

New theme: lucario.

Commits

The new version differs by 20 commits.

  • 860e951 Mark version 5.36.0
  • d49ef29 Adjust hint.fromList to consistenly use the cursor as end pos
  • e732d0e [show-hint addon] fixed fromList didn't show all completions if the cursor was inside the token
  • dd7f998 [continuelist addon] Fix list numbering error
  • 53d2e8b [lucario theme] Add
  • 8a1479b Allow editor-less documents to combine +-origin history events
  • 45d5e05 [javascript-hint addon] Disable completion in json mode
  • 261d10b [merge addon] Use CSS :after to style scroll-lock icon
  • df4cc22 Fix for mouse events that get sent to the wrong document when the script is being run in a different frame than the editor.
  • 74a71c4 move field creation in TextareaInput to an overridable method
  • 708667b [multiplex addon] Fix bug with indentation
  • df4a306 [markdown mode] detecting xml mode inside markdown
  • 563e0ef [realworld uses] Add BNF Playground
  • 8ff6a40 [velocity mode] Properly highlight variables with dash
  • c1ec14b [soy mode] Support kind="trusted_resource_uri" (#5279)

There are 20 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those donā€™t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot šŸŒ“


This change isā€‚Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.748% when pulling 6eb9603 on greenkeeper/codemirror-5.36.0 into 2f9df4b on master.

1 similar comment
@coveralls
Copy link

coveralls commented Mar 20, 2018

Coverage Status

Coverage remained the same at 91.748% when pulling 6eb9603 on greenkeeper/codemirror-5.36.0 into 2f9df4b on master.

@kucherenko kucherenko merged commit 37433e2 into master Mar 21, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/codemirror-5.36.0 branch March 21, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants