Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codemirror to the latest version 🚀 #153

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jul 20, 2018

Version 5.39.2 of codemirror was just published.

Dependency codemirror
Current Version 5.39.0
Type dependency

The version 5.39.2 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of codemirror.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Release Notes 5.39.2

Version 5.39.2

Bug fixes

Fix issue where when you pass the document as a Doc instance to the CodeMirror constructor, the mode option was ignored.

Fix bug where line height could be computed wrong with a line widget below a collapsed line.

Fix overeager .npmignore dropping the bin/source-highlight utility from the distribution.

show-hint addon: Fix behavior when backspacing to the start of the line with completions open.

Commits

The new version differs by 16 commits.

  • 4334727 Mark release 5.39.2
  • 0314530 Make sure bin/source-highlight is in the distribution
  • 81fdc6f When lineWidget changed, do not update hidden lines' height.
  • 5793df5 Adding test lineWidgetIssue5486 for #5486
  • 672523f [soy mode] Highlight command wrapped right after command
  • c11f34f [clike mode] Simplify hooks.indent interface
  • e338ab2 [clike] update kotlin indents
  • 91f3711 Make sure mode option is applied even when a pre-initialized doc is given
  • f301c1c [sql mode] Add deny as keyword for spark sql
  • ccdb216 [themes] update darcula matchingbracket
  • 44b554f Document direction option
  • f9e56e8 [markdown mode] Better support for nested brackets in link text
  • 70408ce [show-hints] support themes
  • ed8dfeb Put fallthrough in quotes for consistency with other keys
  • d1063d2 [show-hint addon] Fix bug where hint at start of line didn't close on backspace

There are 16 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴


This change is Reviewable

@coveralls
Copy link

coveralls commented Jul 20, 2018

Coverage Status

Coverage remained the same at 92.01% when pulling 4d256f0 on greenkeeper/codemirror-5.39.2 into 44b19fb on master.

@kucherenko kucherenko merged commit 7f7c201 into master Jul 20, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/codemirror-5.39.2 branch July 20, 2018 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants