Change limit to FLOAT and add silent mode #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for PR, I will add the code to the repo, but may I ask you to fix build, as I can see we have some lint issues? |
|
Sorry, first time with coffeescript :) |
|
Seems OK now. |
|
Thank you, added to jscpd@0.6.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Implement silent mode according to Avoid print of list of duplication #152
Change the limit type from NUMBER to FLOAT to provide more accurate threshold.
Sometimes the integer threshold not enough to catch code duplication of 50 lines because it less than 1%
This change is