Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug between Todoist and Firefox #11

Closed
kud opened this issue Oct 14, 2014 · 14 comments
Closed

Bug between Todoist and Firefox #11

kud opened this issue Oct 14, 2014 · 14 comments

Comments

@kud
Copy link
Owner

kud commented Oct 14, 2014

Context

Use case

  • Go to a website which has a hashbang like Bug between Todoist and Firefox #11 (comment) (the link must have a hashbang)
  • Add a task like https://mail.google.com/mail/u/0/#inbox/1490ef3c7f1be523 in todoist
  • Click on the task
  • You'll get https://github.com/putaindecode/fix-all-the-things/issues/11#inbox/1490ef3c7f1be523, firefox won't change the domain, just the hashbang.

Example in video: https://cloudup.com/files/ikFJvUOmJCn/download

It works well on Chrome though.

Code in todoist (via browser toolbox):

<span class="text">
  <a href="https://mail.google.com/mail/u/0/#inbox/1490ef3c7f1be523" class="ex_link" target="_blank" onclick="return linkRedirecter(this)">
    <img src="https://d3ptyyxy2at9ui.cloudfront.net/76084e29cb2cf72b320e888edc583dfb.gif" class="cmp_email" width="16">
https://mail.google.com/mail/u/0/#inbox/1490ef3c7f1be523</a>
    <span style="visibility: hidden;" class="clickable note_icon"><img class="cmp_note clickable" src="https://d3ptyyxy2at9ui.cloudfront.net/76084e29cb2cf72b320e888edc583dfb.gif" width="15" height="14"></span>
  <div></div>
</span>

It could be onclick="return linkRedirecter(this)" or https://bugzilla.mozilla.org/show_bug.cgi?id=483304 ?

@kud kud added the bug label Oct 14, 2014
@hallvors
Copy link

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

Okay, let's talk about it there so for the moment. Thank you @hallvors :)

@binki
Copy link

binki commented Oct 14, 2014

Please explain how location.hash being unescaped on firefox causes problems with todoist. How are you even using todoist? Via some browser exstension or a bookmarklet? How do you click on a todoist entry without your URI being something like https://en.todoist.com/app?

@kbrosnan
Copy link

The place to talk about Gecko bugs would be https://lists.mozilla.org/listinfo/dev-platform

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

@binki I've updated the use case. ;) See #11 (comment)

@binki
Copy link

binki commented Oct 14, 2014

Looks to me like a bug in how todoist tries to be smart and reuse your existing GMail tab to open the email link in or something like that. Quite sure that the bugzilla bug you reference is completely unrelated and you were just bugspamming :-p.

@binki
Copy link

binki commented Oct 14, 2014

To work around, just logout of the todoist addon and then log back in before ever clicking a link in todoist.

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

Logout and login didn't change anything.

@binki
Copy link

binki commented Oct 14, 2014

Does for me: http://youtu.be/PlfBU88Y3-w

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

Oh yes, sorry. Yes it works like that, but when you click on the second time, it doesn't work anymore. Not really useful.

@binki
Copy link

binki commented Oct 14, 2014

Then complain to Todoist :-p

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

You're right @binki :)

@hallvors
Copy link

(Apologies if that was a wild goose chase - I should probably have investigated more in-depth, but I've seen a few compat problems caused by the hash escape/unescape incompatibility. https://bugzilla.mozilla.org/show_bug.cgi?id=1025589#c6 is a bad one. So I'd check that out first ;))

@kud
Copy link
Owner Author

kud commented Oct 14, 2014

Answer from todoist: https://twitter.com/todoist/status/522092558760304641

I don't know who is in fault for the moment. I'll try to go deeper too.

@kud kud closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants