adding support for template range

Signed-off-by: Ken Sipe <kensipe@gmail.com>
kudobuilder · Apr 6, 2020 · 0ae6575 · 0ae6575
1 parent 41820b3
commit 0ae6575
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/pkg/kudoctl/packages/verifier/template/parser.go b/pkg/kudoctl/packages/verifier/template/parser.go
@@ -99,10 +99,10 @@ func walkNodes(node parse.Node, fname string, nodeMap map[string]map[string]bool
 		for _, n := range node.Nodes {
 			walkNodes(n, fname, nodeMap)
 		}
-	case *parse.RangeNode: // no support for Range, Template or TextNodes
-		clog.V(2).Printf("file %q has a template range: node: %s", fname, node)
+	case *parse.RangeNode:
+		walkNodes(node.List, fname, nodeMap)
 		walkPipes(node.Pipe, nodeMap)
-	case *parse.TemplateNode:
+	case *parse.TemplateNode: // no support Template or TextNodes
 		clog.V(2).Printf("file %q has a template node: node: %s", fname, node)
 	case *parse.TextNode:
 	default:

diff --git a/pkg/kudoctl/packages/verifier/template/verify_parameters_test.go b/pkg/kudoctl/packages/verifier/template/verify_parameters_test.go
@@ -16,7 +16,7 @@ func TestTemplateParametersVerifier(t *testing.T) {
 		{Name: "NotUsed"},
 		{Name: "UsedViaRoot"},
 		{Name: "BROKER_COUNT"},
-		//{Name: "EXTERNAL_NODE_PORT"},
+		{Name: "EXTERNAL_NODE_PORT"},
 	}
 	paramFile := packages.ParamsFile{Parameters: params}
 	templates := make(map[string]string)
@@ -36,6 +36,12 @@ func TestTemplateParametersVerifier(t *testing.T) {
 ## param used in range (int) should be counted as param
 {{ range $i, $v := until (int .Params.BROKER_COUNT) }}
 {{ end }}
+
+## range example should see EXTERNAL_NODE_PORT
+{{ range $i, $v := until (int .Params.BROKER_COUNT) }}
+- containerPort: {{ add (int $.Params.EXTERNAL_NODE_PORT) $v}}
+  name: node-port-{{ $v }}
+{{ end }}
 `
 	operator := packages.OperatorFile{
 		Tasks: []v1beta1.Task{