-
Notifications
You must be signed in to change notification settings - Fork 104
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: - controller-runtime to 0.5.1 - kubectl to 0.17.3 Gotchas: For some harness tests, I had to edit our test CRDs like: ``` - name: mycrds.mycrd.k8s.io + name: mycrds.mycrd.example.com ``` With new kubectl version, the original name had multiple problems: - names ending with `k8s.io` are restricted and now require an `api-approved.kubernetes.io` annotation pointing to a PR which introduced them - adding this annotation proved challenging since we then see a new transition condition with the `reason: ApprovedAnnotation` thus bringing the number of `status.condition` s to three. These conditions would sometimes arrive out of order, however, test harness does not support the same order of elements when comparing two arrays, thus making the tests flaky. See [this thread](#1420 (comment)) for more details: Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
- Loading branch information
Aleksey Dukhovniy
committed
Mar 18, 2020
1 parent
b5f1f29
commit 452c5b6
Showing
25 changed files
with
186 additions
and
163 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.