Return an error if a resource with a given GVK is missing in the API …

…resource list

pkg/engine/task/task_apply.go

@@ -129,7 +129,11 @@ func isNamespaced(r runtime.Object) (bool, error) {
 	}
 
 	gvk := r.GetObjectKind().GroupVersionKind()
-	return namespaced[gvk], nil
+	res, ok := namespaced[gvk]
+	if !ok {
+		return false, fmt.Errorf("a resource with GVK %v seems to be missing in API resource list", gvk)
+	}
+	return res, nil
 }
 
 // patch calls update method on kubernetes client to make sure the current resource reflects what is on server

pkg/engine/task/task_apply_test.go

@@ -10,7 +10,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
-	"k8s.io/apimachinery/pkg/runtime/schema"
 	"k8s.io/client-go/kubernetes/scheme"
 	"sigs.k8s.io/controller-runtime/pkg/client/fake"
 	"sigs.k8s.io/yaml"
@@ -190,12 +189,3 @@ type errorEnhancer struct{}
 func (k *errorEnhancer) Apply(templates map[string]string, metadata renderer.Metadata) ([]runtime.Object, error) {
 	return nil, errors.New("always error")
 }
-
-func Test_namespacedGVKResources(t *testing.T) {
-	got, err := namespacedGVKResources()
-	assert.NoError(t, err)
-
-	// just a small sanity check
-	assert.True(t, got[schema.GroupVersionKind{Group: "apps", Version: "v1", Kind: "ReplicaSet"}])
-	assert.False(t, got[schema.GroupVersionKind{Group: "apiextensions.k8s.io", Version: "v1", Kind: "CustomResourceDefinition"}])
-}