Skip to content

Commit

Permalink
Rename UnknownTaskKind to TaskBuildError (#1520)
Browse files Browse the repository at this point in the history
Summary:
previously, building a task would only fail for `UnknownTaskKind` reason. However, we're past that and have more error reasons e.g. validation. For now, the reason is kept generic, but we might revisit this should the need arise.

Signed-off-by: Aleksey Dukhovniy <alex.dukhovniy@googlemail.com>
  • Loading branch information
Aleksey Dukhovniy committed May 15, 2020
1 parent f3183ae commit b10d869
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/engine/workflow/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (

var (
unknownTaskNameEventName = "UnknownTaskName"
unknownTaskKindEventName = "UnknownTaskKind"
taskBuildError = "TaskBuildError"
missingPhaseStatus = "MissingPhaseStatus"
missingStepStatus = "MissingStepStatus"
)
Expand Down Expand Up @@ -160,7 +160,7 @@ func Execute(pl *ActivePlan, em *engine.Metadata, c client.Client, di discovery.
phaseStatus.Set(v1beta1.ExecutionFatalError)
return planStatus, engine.ExecutionError{
Err: err,
EventName: unknownTaskKindEventName,
EventName: taskBuildError,
}
}

Expand Down

0 comments on commit b10d869

Please sign in to comment.