Skip to content

Commit

Permalink
Print detailed error when installing package.
Browse files Browse the repository at this point in the history
  • Loading branch information
harryge00 committed Jan 27, 2020
1 parent e737ccd commit c18b6c2
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/kudoctl/packages/resolver/resolver.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ func New(repo *repo.Client) *PackageResolver {
// - an operator name in the remote repository
// in that order. Should there exist a local folder e.g. `cassandra` it will take precedence
// over the remote repository package with the same name.
func (m *PackageResolver) Resolve(name string, appVersion string, operatorVersion string) (*packages.Package, error) {
func (m *PackageResolver) Resolve(name string, appVersion string, operatorVersion string) (b *packages.Package, err error) {

// Local files/folder have priority
if _, err := m.local.fs.Stat(name); err == nil {
if _, err = m.local.fs.Stat(name); err == nil {
clog.V(2).Printf("local operator discovered: %v", name)
b, err := m.local.Resolve(name, appVersion, operatorVersion)
b, err = m.local.Resolve(name, appVersion, operatorVersion)
if err != nil {
return nil, err
}
Expand All @@ -56,17 +56,17 @@ func (m *PackageResolver) Resolve(name string, appVersion string, operatorVersio
clog.V(3).Printf("no local operator discovered, looking for http")
if http.IsValidURL(name) {
clog.V(3).Printf("operator using http protocol for %v", name)
b, err := m.uri.Resolve(name, appVersion, operatorVersion)
b, err = m.uri.Resolve(name, appVersion, operatorVersion)
if err != nil {
return nil, err
}
return b, nil
}

clog.V(3).Printf("no http discovered, looking for repository")
if b, err := m.repo.Resolve(name, appVersion, operatorVersion); err == nil {
if b, err = m.repo.Resolve(name, appVersion, operatorVersion); err == nil {
return b, nil
}

return nil, fmt.Errorf("resolver: unable to find packages for %v", name)
return nil, fmt.Errorf("resolver: unable to find packages for %v: %v", name, err)
}

0 comments on commit c18b6c2

Please sign in to comment.