Emit no error for missing parameter when default present (#581)

kudobuilder · Jul 16, 2019 · d9b5a33 · d9b5a33
1 parent c8bb3c6
commit d9b5a33
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller/instance/instance_controller.go b/pkg/controller/instance/instance_controller.go
@@ -404,7 +404,7 @@ func (r *ReconcileInstance) Reconcile(request reconcile.Request) (reconcile.Resu
 
 	// Make sure all the required parameters in the operatorVersion are present
 	for _, param := range ov.Spec.Parameters {
-		if param.Required {
+		if param.Required && param.Default == nil {
 			if _, ok := instance.Spec.Parameters[param.Name]; !ok {
 				r.recorder.Event(instance, "Warning", "MissingParameter", fmt.Sprintf("Missing parameter \"%v\" required by operatorversion \"%v\"", param.Name, ov.Name))
 			}