No panic when getting a plan status for an instance with no plan (#461)

In certain edge case situations (like a controller outage) an instance might not have an `activePlan.status` set. This fixes a cli panic when querying a plan status for such an instance.

Issues: #459

go.mod

@@ -17,7 +17,7 @@ require (
 	github.com/go-playground/universal-translator v0.16.0 // indirect
 	github.com/go-test/deep v1.0.1
 	github.com/gobuffalo/envy v1.6.15 // indirect
-	github.com/gogo/protobuf v1.2.0 // indirect
+	github.com/gogo/protobuf v1.2.0
 	github.com/golang/groupcache v0.0.0-20190129154638-5b532d6fd5ef // indirect
 	github.com/golang/protobuf v1.3.1 // indirect
 	github.com/google/go-github v17.0.0+incompatible
@@ -41,7 +41,7 @@ require (
 	github.com/prometheus/procfs v0.0.0-20190209105433-f8d8b3f739bd // indirect
 	github.com/rogpeppe/go-internal v1.2.2 // indirect
 	github.com/spf13/cobra v0.0.3
-	github.com/spf13/pflag v1.0.3 // indirect
+	github.com/spf13/pflag v1.0.3
 	github.com/stretchr/testify v1.3.0
 	github.com/xlab/treeprint v0.0.0-20181112141820-a009c3971eca
 	golang.org/x/crypto v0.0.0-20190424203555-c05e17bb3b2d // indirect
@@ -62,7 +62,8 @@ require (
 	k8s.io/apimachinery v0.0.0-20190404173353-6a84e37a896d
 	k8s.io/client-go v11.0.1-0.20190409021438-1a26190bd76a+incompatible
 	k8s.io/code-generator v0.0.0-20181117043124-c2090bec4d9b
-	k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6 // indirect
+	k8s.io/gengo v0.0.0-20190128074634-0689ccc1d7d6
+	k8s.io/klog v0.3.0
 	k8s.io/kube-openapi v0.0.0-20190208205540-d7c86cdc46e3 // indirect
 	sigs.k8s.io/controller-runtime v0.2.0-beta.1.0.20190619203651-3bc157084f53
 	sigs.k8s.io/controller-tools v0.1.11

pkg/controller/planexecution/planexecution_controller.go

@@ -17,11 +17,12 @@ package planexecution
 
 import (
 	"context"
+	"encoding/json"
 	"fmt"
 	"log"
 	"strconv"
 
-	"k8s.io/apimachinery/pkg/util/json"
+	apijson "k8s.io/apimachinery/pkg/util/json"
 
 	kudoengine "github.com/kudobuilder/kudo/pkg/engine"
 
@@ -489,11 +490,11 @@ func (r *ReconcilePlanExecution) Reconcile(request reconcile.Request) (reconcile
 				key, _ := client.ObjectKeyFromObject(obj)
 				truth := obj.DeepCopyObject()
 				err := r.Client.Get(context.TODO(), key, truth)
-				rawObj, _ := json.Marshal(obj)
+				rawObj, _ := apijson.Marshal(obj)
 				if err == nil {
 					log.Printf("PlanExecutionController: CreateOrUpdate Object present")
 					//update
-					log.Printf("Going to apply patch\n%+v\n\n to object\n%+v\n", string(rawObj), truth)
+					log.Printf("Going to apply patch\n%+v\n\n to object\n%s\n", string(rawObj), prettyPrint(truth))
 					if err != nil {
 						log.Printf("Error getting patch between truth and obj: %v\n", err)
 					} else {
@@ -525,7 +526,7 @@ func (r *ReconcilePlanExecution) Reconcile(request reconcile.Request) (reconcile
 				}
 				err = health.IsHealthy(r.Client, obj)
 				if err != nil {
-					log.Printf("PlanExecutionController: Obj is NOT healthy: %+v", obj)
+					log.Printf("PlanExecutionController: Obj is NOT healthy: %s", prettyPrint(obj))
 					planExecution.Status.Phases[i].Steps[j].State = kudov1alpha1.PhaseStateInProgress
 					planExecution.Status.Phases[i].State = kudov1alpha1.PhaseStateInProgress
 				}
@@ -621,3 +622,8 @@ func (r *ReconcilePlanExecution) Cleanup(obj runtime.Object) error {
 
 	return nil
 }
+
+func prettyPrint(i interface{}) string {
+	s, _ := json.MarshalIndent(i, "", "  ")
+	return string(s)
+}

pkg/kudoctl/cmd/plan/plan_status.go

@@ -3,6 +3,7 @@ package plan
 import (
 	"encoding/json"
 	"fmt"
+	"log"
 
 	kudov1alpha1 "github.com/kudobuilder/kudo/pkg/apis/kudo/v1alpha1"
 	"github.com/kudobuilder/kudo/pkg/kudoctl/util/check"
@@ -142,6 +143,10 @@ func planStatus(options *statusOptions) error {
 		Resource: "planexecutions",
 	}
 
+	if instance.Status.ActivePlan.Name == "" {
+		log.Printf("No active plan exists for instance %s", instance.Name)
+		return nil
+	}
 	activePlanObj, err := dynamicClient.Resource(planExecutionsGVR).Namespace(options.namespace).Get(instance.Status.ActivePlan.Name, metav1.GetOptions{})
 	if err != nil {
 		return err