test/manitests/kudo.yaml is not regenerated from source

[porridge]

What happened:

I ran git checkout master && git pull && make integration-test. It failed with plenty of issues such as:

            logger.go:37: 09:14:25 | install-existing-crds-in-operator/0-install-operator | Error: failed to install instance crd-instance: installing Instance: Instance.kudo.dev "crd-instance" is invalid: []: Invalid value: map[string]interface {}{"apiVersion":"kudo.dev/v1beta1", "kind":"Instance", "metadata":map[string]interface {}{"creationTimestamp":"2020-03-10T08:14:25Z", "generation":1, "labels":map[string]interface {}{"kudo.dev/operator":"crd-operator"}, "name":"crd-instance", "namespace":"kudo-test-national-hamster", "uid":"9a95a2a2-b475-4441-b5e0-bb6135ceae5c"}, "spec":map[string]interface {}{"operatorVersion":map[string]interface {}{"name":"crd-operator-0.1.0"}, "planExecution":map[string]interface {}{}}}: validation failure list:
                spec.planExecution.planName in body is required

What you expected to happen:

Should pass.

How to reproduce it (as minimally and precisely as possible):

git checkout c6155cab7e41c8171365e5071d6ebb2ee07a86da^
make integration-tests
git checkout c6155cab7e41c8171365e5071d6ebb2ee07a86da
make integration-tests

Anything else we need to know?:

#1352 removed the required tag from spec.planExecution.planName from the Instance CRD, and apparently started populating spec.PlanExecution to an empty struct.

This works fine, as long as an up-to-date CRD is used. However apparently once our test infra creates test/manitests/kudo.yaml it never updates it if it exists. Therefore the tests on my workstation used a stale CRD, which failed the tests.

This will most likely also hit people who update the kudo controller without updating the CRD, so perhaps it's something worth mentioning in release notes. cc @kensipe @zen-dog

Environment:

• Kubernetes version (use kubectl version):
• Kudo version (use kubectl kudo version):
• Operator:
• operatorVersion:
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[porridge]

Workaround: rm test/manifests/kudo.yaml

[kensipe]

@ANeumann82 this should be noted as part of our upgrade kep

[zen-dog]

We've removed kudo.yaml altogether.