Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install --wait #1418

Closed
kensipe opened this issue Mar 11, 2020 · 0 comments · Fixed by #1461
Closed

Install --wait #1418

kensipe opened this issue Mar 11, 2020 · 0 comments · Fixed by #1461
Assignees
Projects
Milestone

Comments

@kensipe
Copy link
Member

kensipe commented Mar 11, 2020

This was partially implemented on #966 but needs the following:

we need wait for more than just install. So we should have a separate function for wait on a plan.
the wait should be part of the kudo.Client allowing it to be used as a lib... for instance for terraform
It is likely we need to change the timeout for waits (I was initially thinking timeout was defined when acquiring a kudo.Client but I can see wait requiring it for each invocation.
the wait should work for an update, the code for terraform provide is a good start: https://github.com/runyontr/terraform-provider-kudo/blob/master/kudo/resource_kudo_instance.go#L547-L576. however it doesn't work well for update. It needs to check the meta.generation to verify that the plan actually started. Without the meta.generation it is possible that the "last plan" is "finished" and that is the wait func view of the world... which is incorrect.
To narrow the scope... we are not looking for wait to work with upgrade and update... just that the solution should have that in mind and provide a solution that can be leveraged.

more details are likely on the #966 PR

@kensipe kensipe added this to the 0.12.0 milestone Mar 11, 2020
@kensipe kensipe self-assigned this Mar 11, 2020
@kensipe kensipe added this to Backlog in KUDO Global via automation Mar 11, 2020
kensipe pushed a commit that referenced this issue Mar 11, 2020
This is the initial work for `install --wait`.   Follow up work to come with issue: #1418

Signed-off-by: Anthony Dahanne <anthony.dahanne@gmail.com>
@kensipe kensipe modified the milestones: 0.12.0, 0.13.0 Apr 9, 2020
KUDO Global automation moved this from Backlog to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
KUDO Global
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant