Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of local frameworks fails #432

Closed
gerred opened this issue Jun 27, 2019 · 0 comments · Fixed by #437
Closed

Installation of local frameworks fails #432

gerred opened this issue Jun 27, 2019 · 0 comments · Fixed by #437
Labels
Projects
Milestone

Comments

@gerred
Copy link
Member

gerred commented Jun 27, 2019

What happened:

When installing an instance from a local framework, try the following:

$GOPATH/src/github.com/kudobuilder/kudo/bin/kubectl-kudo install .

Because the instance is named after the FV and not the Framework, the manager throws the following error:

2019/06/27 09:51:23 PlanExecutionController: Error CreateOrUpdate Object in step "everything": Service "zookeeper-0.1.0-cs" is invalid: metadata.name: Invalid value: "zookeeper-0.1.0-cs": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?')

What you expected to happen:

Successful install, with the name of the framework being the instance name by default.

How to reproduce it (as minimally and precisely as possible):

  1. Install the CLI off of master (make build-cli)
  2. Use the CLI to install the Zookeeper framework from the cloned frameworks repo under the av/zk-kep-9 branch.

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): v1.14.3
  • Kudo version (use kubectl kudo version): 0.3.0-PRE
  • Framework: Zookeeper
  • Frameworkversion: 0.1.0
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@gerred gerred added this to the v0.3.0 milestone Jun 27, 2019
@gerred gerred added this to Ready for Development in KUDO via automation Jun 27, 2019
@gerred gerred moved this from Ready for Development to In progress in KUDO Jun 27, 2019
@gerred gerred moved this from In progress to Review in progress in KUDO Jun 27, 2019
KUDO automation moved this from Review in progress to Done Jun 27, 2019
gerred added a commit that referenced this issue Jun 27, 2019
… for DNS names. Fixes #432 (#437)

* Change default instance name to have random characters

* Add deterministic tests, account for random name, update golden files

* goland imports is terrible

* Update pkg/kudoctl/util/repo/testdata/zk-crd-golden2/framework.golden

Co-Authored-By: Gastón Kleiman <gaston@apache.org>

* Update pkg/kudoctl/util/repo/testdata/zk-crd-golden2/framework.golden

Co-Authored-By: Gastón Kleiman <gaston@apache.org>

* update golden files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
KUDO
  
Done
1 participant