Deploy clean should remove everything, not just CRD #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensipe
approved these changes
Oct 29, 2019
| @@ -81,7 +81,7 @@ deploy: | |||
|
|
|||
| .PHONY: deploy-clean | |||
| deploy-clean: | |||
| go run ./cmd/kubectl-kudo init --crd-only --dry-run --output yaml | kubectl delete -f - | |||
| go run ./cmd/kubectl-kudo init --dry-run --output yaml | kubectl delete -f - | |||
There was a problem hiding this comment.
this is fine... I assume there is awareness that if there is a runtime object removal that this doesn't work. In the past the removal of planexecution caused some issues as the latest version didn't delete the crd... but 👍
There was a problem hiding this comment.
do we surprise anybody by the change in the behavior? wdyt about a new make nuke-all (a debatable name :) ) target that removes everything?
There was a problem hiding this comment.
I think the convention should be XXX-clean removes whatever XXX created. I doubt that many people actually use this to be honest apart from the core team, I would not be afraid of changing this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since deploy is installing everything into a cluster, deploy-clean should remove everything. Right now it was removing just crds.