New schema for params operator file #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerred
approved these changes
Oct 31, 2019
alenkacz
changed the title
zen-dog
reviewed
Nov 1, 2019
pkg/kudoctl/packages/package_test.go
Outdated
| t.Errorf("readParametersFile() error = %v, wantErr %v", err, tt.wantErr) | ||
| return | ||
| } | ||
| if !reflect.DeepEqual(got, tt.want) { |
There was a problem hiding this comment.
Suggested change
| if !reflect.DeepEqual(got, tt.want) { | |
| assert.Equal(t, tt.want, got) |
will also print a nicely formatted diff of two.
zen-dog
reviewed
Nov 1, 2019
pkg/kudoctl/packages/package_test.go
Outdated
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| got, err := readParametersFile(tt.fileBytes) | ||
| if (err != nil) != tt.wantErr { |
There was a problem hiding this comment.
One-liner to replace four:
Suggested change
| if (err != nil) != tt.wantErr { | |
| assert.Equal(t, tt.wantErr, err != nil, "readParametersFile() error = %v, wantErr %v", err, tt.wantErr) |
zen-dog
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes param files one yaml doc, which will allow for a schema to be applied.
Fixes #1011