Removed obsolete operator version fields #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`delete` and `objects` are a remnant of the old API and can be removed now.
zen-dog
commented
Nov 5, 2019
| @@ -108,12 +102,8 @@ type Phase struct { | |||
|
|
|||
| // Step defines a specific set of operations that occur. | |||
| type Step struct { | |||
| Name string `json:"name" validate:"required"` // makes field mandatory and checks if set and non empty | |||
| Tasks []string `json:"tasks" validate:"required,gt=0,dive"` // makes field mandatory and checks if non empty | |||
| Delete bool `json:"delete,omitempty"` // no checks needed | |||
There was a problem hiding this comment.
Actual change: lines 113-116 on the left were removed
nfnt
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deleteandobjectsfields are a remnant of the old API and can be removed now.