Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable status subresource for instance CRD #1044

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

alenkacz
Copy link
Contributor

What this PR does / why we need it:
Currently, our Instance CRD contains status but we don't have status subresource enabled. That means that we're vulnerable to this behavior described in API conventions:

The PUT and POST verbs on objects MUST ignore the "status" values, to avoid accidentally overwriting the status in read-modify-write scenarios. A /status subresource MUST be provided to enable system components to update statuses of resources they manage.

Otherwise, PUT expects the whole object to be specified. Therefore, if a field is omitted it is assumed that the client wants to clear that field's value. The PUT verb does not accept partial updates. 

Fixes #1043

@alenkacz alenkacz merged commit 3dd284f into master Nov 19, 2019
@alenkacz alenkacz deleted the av/status-subresource branch November 19, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable status subresource
2 participants