Make package builds reproducible #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reproducible builder, certain file metadata has to be changed for archives. This is described in https://reproducible-builds.org/docs/archives/. File ordering is guaranteed by afero, file modification times and uid/gid are changed before adding them to the tarball.
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
gerred
approved these changes
Nov 18, 2019
|
To verify that this creates reproducible builds, please run The resulting SHA should be |
|
Let me see that this can be an integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For reproducible builder, certain file metadata has to be changed for archives. This is described in https://reproducible-builds.org/docs/archives/. File ordering is guaranteed by afero, file modification times and uid/gid are changed before adding them to the tarball.
Fixes #1066