Refactoring of plan_status and first unit tests #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zen-dog
approved these changes
Nov 21, 2019
pkg/kudoctl/cmd/plan.go
Outdated
| }, | ||
| } | ||
|
|
||
| statusCmd.Flags().StringVar(&options.Instance, "instance", "", "The instance name available from 'kubectl get instances'") | ||
| if err := statusCmd.MarkFlagRequired("instance"); err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
we don't panic much. wdyt about:
Suggested change
| panic(err) | |
| clog.V(0).Print("failed to makr --instance flag as required: %v", err) | |
| os.Exit(1) |
zen-dog
reviewed
Nov 22, 2019
pkg/kudoctl/cmd/plan.go
Outdated
| }, | ||
| } | ||
|
|
||
| statusCmd.Flags().StringVar(&options.Instance, "instance", "", "The instance name available from 'kubectl get instances'") | ||
| if err := statusCmd.MarkFlagRequired("instance"); err != nil { | ||
| clog.Printf("failed to make --instance flag as required: %v", err) |
There was a problem hiding this comment.
Suggested change
| clog.Printf("failed to make --instance flag as required: %v", err) | |
| clog.Printf("failed to mark --instance flag as required: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is follow-up of #1050
It stops using dynamicclient in this command and introduces first unit tests for the output.
This PR does not aim to add full test coverage for that command but from that point on, it will be easier to add tests when needed.