Remove a problematic test and add a basic Dispatchfile #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `go test` itself is being run on a (kind) cluster, this test fails
with:
```
W1119 10:50:47.569598 12523 client_config.go:541] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work.
--- FAIL: TestNewK2oClient (0.01s)
kudo_test.go:32: assertion failed: expected error to contain "invalid configuration: no configuration has been provided", got operators: customresourcedefinitions.apiextensions.k8s.io "operators.kudo.dev" is forbidden: User "system:serviceaccount:dispatch:local-runner" cannot get resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope
```
This is because of [this special case in `BuildConfigFromFlags`](https://github.com/kubernetes/client-go/blob/571c0ef67034a5e72b9e30e662044b770361641e/tools/clientcmd/client_config.go#L542-L546)
which falls back to `restclient.InClusterConfig()` when available.
Regardless of whether this config is usable in a `dispatch` kind cluster
or not, this special case proves the assumption that this test makes
("it is not possible to create a client without a config") wrong in
general.
Therefore removing this test altogether seems like the best course of
action.
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A baby step towards resolving #1054
Regarding the test:
When
go testitself is being run on a (kind) cluster, this test failswith:
This is because of this special case in
BuildConfigFromFlagswhich falls back to
restclient.InClusterConfig()when available.Regardless of whether this config is usable in a
dispatchkind cluster ornot, this special case proves the assumption that this test makes
("it is not possible to create a client without a config") wrong in
general.
Therefore removing this test altogether seems like the best course of
action.