Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl-kudo flag conflict #1120 #1121

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix kubectl-kudo flag conflict #1120 #1121

merged 2 commits into from
Dec 2, 2019

Conversation

sharego
Copy link
Contributor

@sharego sharego commented Nov 30, 2019

What this PR does / why we need it:
Fixes #1120

alenkacz
alenkacz approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus the comment from @zen-dog

zen-dog
zen-dog approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@zen-dog zen-dog merged commit 31c57b8 into kudobuilder:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alenkacz alenkacz alenkacz approved these changes

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

@kensipe kensipe Awaiting requested review from kensipe kensipe is a code owner

@nfnt nfnt Awaiting requested review from nfnt nfnt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic when executing cli kubectl-kudo package params list --help
3 participants
@sharego @alenkacz @zen-dog