Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example, add links, mention make import #1154

Merged
merged 7 commits into from
Dec 16, 2019
Merged

Fix example, add links, mention make import #1154

merged 7 commits into from
Dec 16, 2019

Conversation

porridge
Copy link
Member

@porridge porridge commented Dec 10, 2019 •
edited
Loading

What this PR does / why we need it:

  • move a k8s.io import to correct section in example
  • mention make import
  • add links to code conventions

@porridge
Fix example, add links
4a636f7 
* move a k8s.io import to correct section in example
* add links to code conventions
zen-dog
zen-dog approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@zen-dog zen-dog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

STYLEGUIDE.md Show resolved Hide resolved
@porridge porridge changed the title Fix example, add links Fix example, add links, mention make import Dec 10, 2019
alenkacz
alenkacz approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

nfnt
nfnt requested changes Dec 10, 2019
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "imports" section is not up-to-date with what's linted by goimports. Shall we fix this as part of this PR? Happy to create a follow-up or commit something on top here.

STYLEGUIDE.md Outdated Show resolved Hide resolved
STYLEGUIDE.md Show resolved Hide resolved
STYLEGUIDE.md Outdated Show resolved Hide resolved
@porridge porridge requested a review from nfnt December 16, 2019 16:42
@kensipe
modified import structures and removed golang references. the name is…
49f6ba9 
… go:)

Signed-off-by: Ken Sipe <kensipe@gmail.com>
nfnt
nfnt approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is now aligned with what's used in our code. 🚢

STYLEGUIDE.md Outdated Show resolved Hide resolved
@kensipe
Update STYLEGUIDE.md
f719348 
Co-Authored-By: Jan Schlicht <jan@d2iq.com>
@kensipe kensipe merged commit a90277d into master Dec 16, 2019
@kensipe kensipe deleted the porridge-patch-1 branch December 16, 2019 21:12
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
@porridge @ANeumann82
Fix example, add links, mention make import (#1154)
6111626 
Co-Authored-By: Jan Schlicht <jan@d2iq.com>
Co-Authored-By:  Ken Sipe <kensipe@gmail.com>


Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kensipe kensipe kensipe approved these changes

@alenkacz alenkacz alenkacz approved these changes

@nfnt nfnt nfnt approved these changes

@zen-dog zen-dog zen-dog approved these changes

@gerred gerred Awaiting requested review from gerred gerred is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@porridge @kensipe @alenkacz @nfnt @zen-dog