-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a pre-commit hook to check for signed-off commits #1168
Conversation
Signed-off-by: Jan Schlicht <jan@d2iq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find that I'm against this. we need to talk as a team regarding this
this new process has many open questions to be answered... If the sign-off is missing... does any committer sign off on it? There is NO value to the sign-off for committers (it is for patches). Why would we require our internal team to sign-off on something that we already know they are in agreement with (DCO) with a token that is used for other purposes. Why would we change their workflow with something that doesn't add any value? I'm strongly opposed to this |
Closing this, as we need to decide on our approach first. |
Reopening, as we're now enforcing DCO and this hook can be helpful if enabled. |
Running 'make lint' instead of using an upstream 'golangci-lint' ensures that the version of 'golangci-lint' set in 'hack/install-golangcilint.sh' is used. Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Jan Schlicht <jan@d2iq.com> Signed-off-by: Thomas Runyon <runyontr@gmail.com>
What this PR does / why we need it:
In addition to #1164 this adds a commit hook configuration for pre-commit to check for signed-off commits.