Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pre-commit hook to check for signed-off commits #1168

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

nfnt
Copy link
Member

@nfnt nfnt commented Dec 11, 2019

What this PR does / why we need it:
In addition to #1164 this adds a commit hook configuration for pre-commit to check for signed-off commits.

$ git commit -s
golangci-lint........................................(no files to check)Skipped
signed-off-commits.......................................................Passed

Signed-off-by: Jan Schlicht <jan@d2iq.com>
Copy link
Member

@kensipe kensipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that I'm against this. we need to talk as a team regarding this

@kensipe
Copy link
Member

kensipe commented Dec 16, 2019

this new process has many open questions to be answered...
like Co-authored-by: needs to be last lines in the the commit message... now we have
Signed-off-by: which also needs to be last lines. Do they work together?

If the sign-off is missing... does any committer sign off on it?

There is NO value to the sign-off for committers (it is for patches). Why would we require our internal team to sign-off on something that we already know they are in agreement with (DCO) with a token that is used for other purposes. Why would we change their workflow with something that doesn't add any value?

I'm strongly opposed to this

@nfnt
Copy link
Member Author

nfnt commented Dec 18, 2019

Closing this, as we need to decide on our approach first.

@nfnt nfnt closed this Dec 18, 2019
@nfnt
Copy link
Member Author

nfnt commented Feb 12, 2020

Reopening, as we're now enforcing DCO and this hook can be helpful if enabled.

@nfnt nfnt reopened this Feb 12, 2020
Running 'make lint' instead of using an upstream 'golangci-lint' ensures that the version of 'golangci-lint' set in 'hack/install-golangcilint.sh' is used.

Signed-off-by: Jan Schlicht <jan@d2iq.com>
@nfnt nfnt merged commit 47853d3 into master Feb 21, 2020
@nfnt nfnt deleted the nfnt/dco-commit-hook branch February 21, 2020 09:04
runyontr pushed a commit that referenced this pull request Mar 11, 2020
Signed-off-by: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Thomas Runyon <runyontr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants