Wait for the entire assert timeout for resources to be deleted. #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the test timeout was ignored when waiting for resources deleted by a TestStep to disappear. This changes it so that the test assert timeout is respected and used.
jbarrick-mesosphere
requested review from
alenkacz,
gerred,
kensipe and
nfnt
ANeumann82
requested changes
Dec 12, 2019
ANeumann82
approved these changes
Dec 12, 2019
alenkacz
pushed a commit
that referenced
this pull request
Dec 17, 2019
* Wait for the entire assert timeout for resources to be deleted. Previously, the test timeout was ignored when waiting for resources deleted by a TestStep to disappear. This changes it so that the test assert timeout is respected and used. * cast int to time.Duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: