Unify description spelling in cmd and pkg/apis. #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
kensipe
reviewed
Dec 12, 2019
| @@ -77,12 +78,12 @@ spec: | |||
| type: object | |||
| type: array | |||
| templates: | |||
| description: List of go templates YAML files that define the application | |||
| operator instance | |||
| description: Yaml captures a templated yaml list of elements that define | |||
There was a problem hiding this comment.
love most of these changes... except this one. This desc makes no sense to me.
There was a problem hiding this comment.
Yeah, second this, what about: Templates is a list of references to YAML templates located in the templates folder and later referenced from tasks.
alenkacz
approved these changes
Dec 13, 2019
| @@ -77,12 +78,12 @@ spec: | |||
| type: object | |||
| type: array | |||
| templates: | |||
| description: List of go templates YAML files that define the application | |||
| operator instance | |||
| description: Yaml captures a templated yaml list of elements that define | |||
There was a problem hiding this comment.
Yeah, second this, what about: Templates is a list of references to YAML templates located in the templates folder and later referenced from tasks.
This in preparation of moving to generating CRDs from the structs, in order to minimize the diff.
porridge
force-pushed
the
crds-spelling
branch
from
4d1aa8d
to
ab675c1
Compare
|
👍 |
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
This was missed in #1172 Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This in preparation of moving to generating CRDs from the structs, in
order to minimize the diff.
Baby step towards #862