-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include phase strategy in plan status output #1173
Conversation
1ac1ffc
to
2c1d404
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have two small string nits, when we resolve that, this is good to be merged :)
@@ -82,7 +82,7 @@ func TestStatus(t *testing.T) { | |||
. | |||
└── test (Operator-Version: "test-1.0" Active-Plan: "deploy") | |||
└── Plan deploy ( strategy) [FATAL_ERROR] | |||
└── Phase deploy [FATAL_ERROR] | |||
└── Phase deploy ( strategy) [FATAL_ERROR] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not a very nice output :/ but I guess it's fine for now, I'll fix it once we merge it :)
This actually should never happen in real life... ? because the strategy should is mandatory in OV
2c1d404
to
f1061cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Phase strategy can be defined independently of that for a plan, so this commit includes this in the output so that the Operator behaviour is less confusing to the user.
f1061cb
to
58f1a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👏
Phase strategy can be defined independently of that for a plan, so this commit includes this in the output so that the Operator behaviour is less confusing to the user. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
What this PR does / why we need it:
Phase strategy can be defined independently of that for a plan, so this commit includes this in the output so that the Operator behaviour is less confusing to the user.
The output of that command now looks like this:
Fixes #1171