Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use empty json tags to please controller-gen. #1191

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Use empty json tags to please controller-gen. #1191

merged 1 commit into from
Dec 17, 2019

Conversation

porridge
Copy link
Member

What this PR does / why we need it:

This is a re-post of #1181 which was merged into the wrong branch.

Example messages:

pkg/apis/kudo/v1beta1/test_types.go:93:2: encountered struct field "Labels" without JSON tag in type "ObjectReference"
Error: not all generators ran successfully

This does not seem to have any effect otherwise.

This is another baby step towards #862

Co-Authored-By: Jan Schlicht <jan@d2iq.com>
Copy link
Member

@nfnt nfnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alenkacz alenkacz merged commit e5361cb into master Dec 17, 2019
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Co-Authored-By: Jan Schlicht <jan@d2iq.com>
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants