Use the correct type for UpgradableFrom. #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
alenkacz
approved these changes
Dec 18, 2019
| @@ -45,7 +45,7 @@ type OperatorVersionSpec struct { | |||
| Dependencies []OperatorDependency `json:"dependencies,omitempty"` | |||
|
|
|||
| // UpgradableFrom lists all OperatorVersions that can upgrade to this OperatorVersion. | |||
| UpgradableFrom []OperatorVersion `json:"upgradableFrom,omitempty"` | |||
| UpgradableFrom []corev1.ObjectReference `json:"upgradableFrom,omitempty"` | |||
There was a problem hiding this comment.
🤷♀ we don't really use this field, so I wouldn't be against removing it until we know what to do with it :)
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
It seems to me like using the full-blown type with spec, status and all had been a mistake. This field seems unused in the code, so maybe that is why this was missed. This is a baby step towards #862. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It seems to me like using the full-blown type with spec, status and all had been a mistake.
This field seems unused in the code, so maybe that is why this was missed.
This is a baby step towards #862.