Operator Skeleton Generator #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kensipe
requested review from
alenkacz,
gerred,
nfnt and
zen-dog
as code owners
alenkacz
requested changes
Dec 19, 2019
There was a problem hiding this comment.
Let's add the test at least for the non-interactive one and then I think it's good to go
As of how far we want to move this feature I am fine with this scaffolding some general structure of the operator, with folders and everything, I am not sure I would go as far as defining tasks from CLI. Since we're dealing with yaml and not ruby, I think people are able to write yaml even without interactive prompts
pkg/kudoctl/cmd/package_new.go
Outdated
|
|
||
| // run returns the errors associated with cmd env | ||
| func (pkg *packageNewCmd) run() error { | ||
| folderDefault := "operator" |
There was a problem hiding this comment.
why not default to something like operator-$operatorName
There was a problem hiding this comment.
this is consistent with 80%+ of our repo...
alenkacz
approved these changes
Dec 20, 2019
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
kensipe
force-pushed
the
ken/skel-operator
branch
from
4eea516
to
d2f136a
Compare
|
resolved all pr feedback... thanks alenkacz ! |
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Provides the ability to generate a new operator with: `kudo package new foo` Also provides a way to generate a new operator interactively with `kudo package new -i foo Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Creates the start of an operator via walking thru validated prompts. Expectations are:
operator.yamlfile in the current directory (which assumes that you are in an operator folder.Answering the prompts will result in:
NOT included:
there will be a separate generator for them
Added to flags
--interactiveand--overwrite. The default now goes with defaults and creates the operator.-igoes into interactive mode where questions are asked to fill in the detail.-wallows for an overwrite of an existing operator. Initially I didn't like the-wbecause I wanted to potentially have an interactivepackage updatevspackage newwhich is suppose to be new. BUT... I can see the case that someone created with defaults and wants to do it "interactive"Fixes #1085