When building binaries, compile the whole package. #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we have a single file so the effect is the same. But it might save us some frustration if we ever add more, and this way shows the intent better.
porridge
requested review from
alenkacz,
gerred,
kensipe,
nfnt and
zen-dog
as code owners
nfnt
approved these changes
Dec 19, 2019
alenkacz
approved these changes
Dec 19, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Currently we have a single file so the effect is the same. But it might save us some frustration if we ever add more, and this way shows the intent better. Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently we have a single file in each of these, so the effect is the same.
However it will save us some frustration if we ever add more, and this way
reflects the intent better.
This was discovered the hard way trying to get
pkgerworking for #862.