Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated parameterDiff method #1215

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Removed duplicated parameterDiff method #1215

merged 2 commits into from
Dec 20, 2019

Conversation

zen-dog
Copy link
Contributor

@zen-dog zen-dog commented Dec 19, 2019

No description provided.

@@ -74,3 +75,27 @@ func TestGetLastExecutedPlanStatus(t *testing.T) {
}
}
}

func TestSpecParameterDifference(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test has been copied from now removed instance_controller_suite_test.go

Copy link
Contributor

@alenkacz alenkacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we're not going with "doppelt hält besser" 😢 😂

@zen-dog zen-dog merged commit 50d5706 into master Dec 20, 2019
@zen-dog zen-dog deleted the ad/rm-param-diff branch December 20, 2019 10:15
ANeumann82 pushed a commit that referenced this pull request Feb 13, 2020
Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants