Refactor KinD usage in test harness and allow to add (local) containers #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the 'kind' struct that is a thin abstraction layer for running KinD clusters. It adds the 'kindContainers' option to the test harness. This option allows to add (local) Docker images to a KinD cluster, e.g. when testing local artifacts.
nfnt
requested review from
alenkacz,
gerred,
jbarrick-mesosphere,
kensipe and
zen-dog
as code owners
jbarrick-mesosphere
approved these changes
Dec 20, 2019
kensipe
approved these changes
Dec 23, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
…rs (#1217) This commit introduces the 'kind' struct that is a thin abstraction layer for running KinD clusters. It adds the 'kindContainers' option to the test harness. This option allows to add (local) Docker images to a KinD cluster, e.g. when testing local artifacts. Signed-off-by: Ken Sipe <kensipe@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In preparation for #1177, this PR refactors the
testpackages to have akindstruct that is a thin abstraction layer for running KinD clusters.It adds the 'kindContainers' option to the test harness. This option allows to add (local) Docker images to a KinD cluster, e.g. when testing local artifacts.
Solves #684