Adds a fix to include CA data in generated kubeconfig #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/test/utils/kubernetes.go
Outdated
| var CAData []byte | ||
| var err error | ||
| if len(cfg.TLSClientConfig.KeyData) != 0 { | ||
| CAData = cfg.TLSClientConfig.CAData |
There was a problem hiding this comment.
Can we use the LoadTLSFiles method instead? https://godoc.org/k8s.io/client-go/rest#LoadTLSFiles
Signed-off-by: faiq <faiqrazarizvi@gmail.com>
faiq
force-pushed
the
adds-ca-to-kubeconfig
branch
from
9a3298b
to
ba5f8a6
Compare
oliviabarrick
approved these changes
Dec 27, 2019
kensipe
approved these changes
Dec 27, 2019
|
noice! |
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Signed-off-by: faiq <faiqrazarizvi@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently when generating KubeConfig Kudo is not reading the files for CA when generating a KubeConfig within the test context that it is running in. This comes into play if you have a component that is using the generated Kubeconfig to make calls to the Kubernetes API within your test. According to the docs ca bundles are handled like so when accessing the k8s api using a service account:
This patch simply reads that file and loads it into the kubeconfig that the rest of the tests use. Here is a spew dump of the TLSConfig from my patched fix:
Please let me know how to proceed!