Get rid of dependency on kustomize in controller #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenkacz
requested review from
gerred,
kensipe,
nfnt and
zen-dog
as code owners
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com>
alenkacz
force-pushed
the
av/kustomize-remove
branch
from
21a0d5c
to
0f5ebd9
Compare
zen-dog
approved these changes
Dec 31, 2019
| v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil" | ||
| "sigs.k8s.io/kustomize/k8sdeps/kunstruct" |
kensipe
approved these changes
Dec 31, 2019
ANeumann82
pushed a commit
that referenced
this pull request
Feb 13, 2020
Signed-off-by: Alena Varkockova <varkockova.a@gmail.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kustomize was quite heavy dependency for ONLY adding annotations, labels and namespaces. This PR just assigns those directly on runtime.Objects (Unstructured). This also fixes cryptic errors we were getting from kustomize.
Fixes #1180
Fixes #1179
Fixes #1163