Run a KUDO deployment for E2E testing #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfnt
force-pushed
the
nfnt/extend-e2e-testing
branch
12 times, most recently
from
a7c8fde
to
265d9dc
Compare
A Docker image of the KUDO manager is built and deployed in the E2E test cluster. This is done by adding the build KUDO image to the KinD cluster and changing the 'kubctl kudo init' output to ensure that this image will be used when deploying KUDO.
nfnt
force-pushed
the
nfnt/extend-e2e-testing
branch
from
265d9dc
to
ea6e801
Compare
nfnt
requested review from
alenkacz,
gerred,
kensipe and
zen-dog
as code owners
ANeumann82
approved these changes
Jan 7, 2020
ANeumann82
reviewed
Jan 7, 2020
ANeumann82
reviewed
Jan 7, 2020
|
|
||
| ./bin/kubectl-kudo init --dry-run --output yaml \ | ||
| | sed -E -e "/image:/ s/:[[:alnum:]]+/:$VERSION/" -e '/imagePullPolicy/ s/Always/Never/' \ | ||
| > test/manifests/kudo.yaml |
There was a problem hiding this comment.
Maybe we should have a file in test/manifests/kudo.yaml with a note that the file will be overwritten all the time? Just to prevent that somebody tries to put a static config there?
There was a problem hiding this comment.
Good point! The tests currently creates artifacts all over the place and doesn't bother with cleaning up temporaries once they're done. This is something that need to be fixed at some point, but independently from this PR. How about having a separate manifests folder for these generated files?
Co-Authored-By: Andreas Neumann <aneumann@mesosphere.com>
ANeumann82
added a commit
that referenced
this pull request
Feb 13, 2020
A Docker image of the KUDO manager is built and deployed in the E2E test cluster. This is done by adding the build KUDO image to the KinD cluster and changing the 'kubectl kudo init' output to ensure that this image will be used when deploying KUDO. Co-Authored-By: Andreas Neumann <aneumann@mesosphere.com> Signed-off-by: Andreas Neumann <aneumann@mesosphere.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A Docker image of the KUDO manager is built and deployed in the E2E test cluster.
This is done by adding the build KUDO image to the KinD cluster and changing the 'kubctl kudo init' output to ensure that this image will be used when deploying KUDO.
Fixes #1177