Store KinD logs artifact in E2E tests

[nfnt]

What this PR does / why we need it:
Updates the CI configuration to storage the cluster logs as tarball. This allows us to better debug CI failures like, e.g., #1235.

[nfnt]

Oh, it isn't that easy, because these test are run in a separate container and we can't access its contents. Have to find a different approach to not use test/Dockerfile.

[nfnt]

By copying the cluster logs from the exited container using docker cp, it is possible to retrieve them in the CI.

[ANeumann82]

lgtm

[porridge]

The first question that springs to my mind is - why not just put the logs into a directory mounted into the container with -v, all the more since we already use this mechanism to expose the reports directory?

Your approach would also work but strikes me as a lot of complexity (random string generation, explicit container name, explicit imperative cleanup, potentially fragile manipulation of kudo-e2e-test.yaml) that could be easily avoided.

[porridge]

Hm, do we really want to continue if this is too short (possibly empty)?

[nfnt]

This is to avoid a SIGPIPE.

[nfnt]

@porridge Yeah, mounting a directory seems to be the easiest approach, I somehow didn't see that we already do this for the reports.

[nfnt]

Mounting directories didn't work due to file permission issues. I'm keeping the docker cp approach.

[porridge]

I ran some experiments, and it turns out that circleci runs the job as user circleci which does not have access to some of the log files which kind creates.

A strategically placed recursive chmod in run_tests.sh is enough to make it work, though.

Could I convince you to go back to the path of exposing these with -v? Apart from being less complex, this would fix the file access issue for any other user of this script...

[nfnt]

@porridge Thanks for looking into this! I'll change this to directory mounts & chmod.

[nfnt]

@porridge Log collection is now using a mounted folder, ptal.

[porridge]

Any particular reason you're telling CircleCi to store the tarball, rather than directly the directory with logs?

[nfnt]

@porridge It's a tarball because when debugging you usually have to look at multiple files to figure out what's wrong. Better have them all at once.

[porridge]

@porridge It's a tarball because when debugging you usually have to look at multiple files to figure out what's wrong. Better have them all at once.

So you cannot browse their content within CircleCI UI? Download only?